Qtfred ship weapons dialog#7453
Merged
wookieejedi merged 17 commits intoMay 16, 2026
Merged
Conversation
TheForce172
reviewed
May 13, 2026
| const int id; | ||
| const bool allowed; | ||
| }; | ||
| class WeaponModel : public QAbstractListModel { |
Contributor
There was a problem hiding this comment.
Kind of concerned here that we're breaking the no QT code in models rule. I thought the model code was supposed to be UI agnostic.
Contributor
Author
There was a problem hiding this comment.
Oof. Yeah. I've been neck deep in new feature code in just qt widgets so long that I wasn't paying attention. Good catch. I've redone it with a better model/ui split.
MjnMixael
force-pushed
the
qtfred-ship-weapons-dialog
branch
from
8a1502a to
9fb58a9
Compare
wookieejedi
approved these changes
May 15, 2026
Member
wookieejedi
left a comment
wookieejedi
left a comment
There was a problem hiding this comment.
With recent push fixing the turret weapon selection this now looks good
github-project-automation
Bot
moved this from Work In Progress (PRs)
to In Review (PRs)
in qtFRED2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades and refactors the ships weapons subdialog. Enables multi edit, drag-and-drop controls of a ship's weapons with several quality of life features such as visually showing which weapons are allowed for a particular ship. Finishes TheForce172's work and brings the final subdialog in line with the rest.
Tests show it working as expected.
The last of what's needed and Fixes #6973